Skip to content

lib: support returning Safe collections from C++ #36989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ExE-Boss wants to merge 2 commits into from
Closed

lib: support returning Safe collections from C++ #36989

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b427d33
lib: support returning Safe collections from C++
ExE-Boss Jan 17, 2021
a1ee533
fixup! lib: support returning Safe collections from C++
ExE-Boss Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! lib: support returning Safe collections from C++ 
Co-authored-by: Antoine du Hamel <[email protected]>
  • Loading branch information
@ExE-Boss @aduh95
ExE-Boss and aduh95 authored Jan 20, 2021
commit a1ee5331b19c8dc31f77318b51777931bb19f565
7 changes: 2 additions & 5 deletions test/parallel/test-options-binding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
'use strict';

const common = require('../common');
const { primordials } = require('internal/test/binding');
const {
SafeMap,
} = primordials;
const { primordials: { SafeMap } } = require('internal/test/binding');

const { options, aliases, getOptionValue } = require('internal/options');
const assert = require('assert');
Expand All @@ -17,5 +14,5 @@ assert(aliases instanceof SafeMap,
"require('internal/options').aliases is a SafeMap");

Map.prototype.get =
common.mustNotCall('%Map.prototype.get% must not be called');
common.mustNotCall('`getOptionValue` must not call user-mutable method');
assert.strictEqual(getOptionValue('--expose-internals'), true);