Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
9852ebc
http: do not loop over prototype in Agent
targos Dec 6, 2020
040b39f
tools: enable no-unused-expressions lint rule
targos Nov 24, 2020
deaafd5
dns: refactor to use more primordials
aduh95 Nov 20, 2020
6a6b3af
doc: provide more context on techinical values
mhdawson Nov 20, 2020
166aa8a
test: fix child-process-pipe-dataflow
santigimeno Dec 3, 2020
d3d1f33
test: add SIGTRAP to test-signal-handler
Dec 3, 2020
023291b
test: check null proto-of-proto in util.inspect()
Trott Dec 5, 2020
169406b
src: add missing context scopes
addaleax Dec 6, 2020
8ecf2f9
tools: update doc tool dependencies
targos Dec 6, 2020
3341b2c
doc: document ABORT_ERR code
benjamingr Nov 29, 2020
02afe58
src: use using declarations consistently
danbev Dec 3, 2020
210390f
src: remove identical V macro
danbev Dec 7, 2020
2a60e3b
src: fix indentation in memory_tracker-inl.h
danbev Dec 7, 2020
31b062d
test: fix flaky test-repl
Trott Dec 6, 2020
5929b08
deps: upgrade npm to 7.1.0
ruyadorno Dec 4, 2020
04f1663
doc: add RaisinTen as a triager
RaisinTen Dec 6, 2020
26f8ccf
tools: update ESLint to 7.15.0
cjihrig Dec 6, 2020
7542a3b
tools: enable no-unsafe-optional-chaining lint rule
cjihrig Dec 6, 2020
e331de2
doc: reword POSIX threads text in addons.md
Trott Dec 7, 2020
dd705ad
test: increase execFile abort coverage
shootermv Dec 7, 2020
e46a46a
inspector: refactor to use more primordials
aduh95 Nov 21, 2020
6ecbc1d
stream: support abortsignal in constructor
benjamingr Dec 7, 2020
129053f
doc: update terminology
mhdawson Dec 10, 2020
1330995
build,lib,test: change whitelist to allowlist
targos Dec 6, 2020
e597882
src: add typedef for CleanupHookCallback callback
danbev Dec 8, 2020
4f3d7bb
src: introduce convenience node::MakeSyncCallback()
nicstange Nov 29, 2020
e2ced0d
perf_hooks: invoke performance_entry_callback via MakeSyncCallback()
nicstange Nov 29, 2020
f368d69
Revert "perf_hooks: make PerformanceObserver an AsyncResource"
nicstange Nov 29, 2020
0f749a3
test: add test for async contexts in PerformanceObserver
ZauberNerd Dec 2, 2020
c6e65d0
tools: update ini in tools/node-lint-md-cli-rollup
MylesBorins Dec 10, 2020
0baa610
deps: upgrade npm to 7.1.1
ruyadorno Dec 9, 2020
e233094
src: allow preventing SetPrepareStackTraceCallback
codebytere Dec 8, 2020
62bfe3d
doc: note v15.0.0 changed default --unhandled-rejections=throw
kaizhu256 Dec 3, 2020
e449571
child_process: add signal support to spawn
benjamingr Dec 7, 2020
13d6597
util: fix module prefixes during inspection
BridgeAR Nov 19, 2020
cc544db
util: fix instanceof checks with null prototypes during inspection
BridgeAR Nov 19, 2020
30fe0ff
deps: upgrade npm to 7.1.2
darcyclarke Dec 11, 2020
58319d5
tls: forward new SecureContext options
mildsunrise Dec 6, 2020
acd78d9
test: increased externalized string length
codebytere Dec 9, 2020
9891811
doc: edit addon text about event loop blocking
Trott Dec 8, 2020
56fe9ba
worker: refactor MessagePort entanglement management
addaleax Dec 1, 2020
96c095f
src: guard against env != null in node_errors.cc
addaleax Dec 6, 2020
21fbcb6
deps: V8: backport 4bf051d536a1
addaleax Dec 11, 2020
5ff7f42
src: use correct outer Context’s microtask queue
addaleax Dec 8, 2020
f7635fd
test: make executable name more general
codebytere Dec 12, 2020
1b4984d
src: remove duplicate V macros in node_v8.cc
danbev Dec 9, 2020
fa40366
util: simplify constructor retrieval in inspect()
Trott Dec 10, 2020
d299cee
test: increase coverage for net/blocklist
Lxxyx Dec 6, 2020
1ec8516
doc: add PoojaDurgad to collaborators
PoojaDurgad Dec 14, 2020
20ecc82
worker: fix broadcast channel SharedArrayBuffer passing
addaleax Dec 13, 2020
25a2454
doc: add v15.4.0 link to CHANGELOG.md
danielleadams Dec 9, 2020
584ea8b
build: fix make test-npm
ruyadorno Dec 3, 2020
22f0393
doc: revise addon mulitple initializations text
Trott Dec 9, 2020
9f2d3c2
test: remove test-http2-client-upload as flaky
Trott Dec 12, 2020
728f512
lib: make safe primordials safe to iterate
aduh95 Dec 4, 2020
d8b5b94
stream: accept iterable as a valid first argument
Lxxyx Dec 11, 2020
68687d3
src: remove empty name check in node_env_var.cc
RaisinTen Nov 16, 2020
109ab78
test: increase coverage for fs/dir read
Lxxyx Dec 4, 2020
7a34452
doc: add license info to the README
iam-frankqiu Nov 26, 2020
c3ec90d
doc: make explicit reverting node_version.h changes
richardlau Dec 9, 2020
81e603b
test: specify global object for globals
Trott Dec 13, 2020
cb4652e
deps: update to c-ares 1.17.1
lxdicted Nov 21, 2020
f09985d
doc: update url.md
aarock1234 Nov 17, 2020
eb29a16
doc: add issue reference to github pr template
chinmoy12c Dec 8, 2020
7b8d373
tools: lint shell scripts
aduh95 Nov 10, 2020
b0393fa
deps: upgrade npm to 7.2.0
MylesBorins Dec 16, 2020
752c94d
deps: fix npm doctor tests for pre-release node
nlf Dec 15, 2020
1f43aad
deps: update patch and docs for openssl update
MylesBorins Dec 14, 2020
27fb651
deps: upgrade openssl sources to 1.1.1i
MylesBorins Dec 14, 2020
309e297
deps: various quic patches from akamai/openssl
tmshort Apr 12, 2019
5b49807
deps: re-enable OPENSSL_NO_QUIC guards
jasnell Jun 24, 2020
b6a31f0
deps: update archs files for OpenSSL-1.1.1i
MylesBorins Dec 15, 2020
7efb311
src: remove unnecessary ToLocalChecked call
danbev Dec 15, 2020
25d7e90
http: use `autoDestroy: true` in incoming message
dnlup May 19, 2020
397e31e
http: reafactor incoming message destroy
dnlup Nov 24, 2020
4b81d79
http: fix lint error in incoming message
dnlup Dec 9, 2020
f11a648
http: add comments in _http_incoming
dnlup Dec 9, 2020
60b5e69
http: remove trailing space
dnlup Dec 11, 2020
36b4ddd
http: use standard args order in IncomingMEssage onError
dnlup Dec 11, 2020
213dcd7
http: add test for incomingmessage destroy
dnlup Dec 16, 2020
9830fe5
doc: move Derek Lewis to emeritus
Trott Dec 14, 2020
c6700ad
tools: remove unused variable in configure.py
Trott Dec 15, 2020
27260c7
tools: fix release script
aduh95 Dec 16, 2020
ad75c78
doc: add note about timingSafeEqual for TypedArray
tniessen Nov 30, 2020
149f2cf
doc: add two tips for speeding the dev builds
mmomtchev Dec 9, 2020
9fc2479
test: increase coverage for worker
Lxxyx Dec 12, 2020
95c80f5
build: run some workflows only on nodejs/node
targos Dec 14, 2020
3f33d0b
stream: fix pipe deadlock when starting with needDrain
ronag Dec 18, 2020
7c903ec
repl: disable blocking completions by default
addaleax Dec 18, 2020
bbc0d14
src: use correct microtask queue for checkpoints
addaleax Dec 19, 2020
e1f00fd
benchmark: reduce code duplication
Trott Dec 18, 2020
f3828c9
tools: fix update-eslint.sh
Dec 19, 2020
0d4d347
tools: update ESLint to 7.16.0
Dec 19, 2020
dc8d1a7
deps: upgrade npm to 7.3.0
ruyadorno Dec 18, 2020
c5602fb
doc: simplify worker_threads.md text
Trott Dec 17, 2020
e3c5adc
tools: fix release script sign function
aduh95 Dec 18, 2020
e30af7b
fs: refactor to use optional chaining
Lxxyx Dec 15, 2020
5481be8
lib: support BigInt in querystring.stringify
RaisinTen Dec 13, 2020
a1ba668
doc: add remark about Collaborators discussion page
iam-frankqiu Dec 7, 2020
9fbab3e
doc: update and run license-builder for Babel
targos Dec 14, 2020
82a2626
build: do not run GitHub actions for draft PRs
targos Nov 1, 2020
036ed1f
src: add way to get IsolateData and allocator from Environment
addaleax Dec 8, 2020
19c2332
doc: fix AbortSignal example for stream.Readable
targos Dec 22, 2020
d38a0ec
src: remove unnecessary ToLocalChecked node_errors
danbev Dec 17, 2020
22ac227
test: increase coverage for stream
Lxxyx Dec 16, 2020
ecbb757
tools: fix make-v8.sh
richardlau Dec 21, 2020
01576fb
test: increase abort logic coverage
shootermv Dec 18, 2020
f978628
2020-12-22, Version 15.5.0 (Current)
targos Dec 21, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fix indentation in memory_tracker-inl.h
PR-URL: #36425
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
danbev authored and targos committed Dec 21, 2020
commit 2a60e3b9dff036629ee724ca5439edd3d7829df6
8 changes: 4 additions & 4 deletions src/memory_tracker-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ inline const char* GetNodeName(const char* node_name, const char* edge_name) {
class MemoryRetainerNode : public v8::EmbedderGraph::Node {
public:
inline MemoryRetainerNode(MemoryTracker* tracker,
const MemoryRetainer* retainer)
const MemoryRetainer* retainer)
: retainer_(retainer) {
CHECK_NOT_NULL(retainer_);
v8::HandleScope handle_scope(tracker->isolate());
Expand All @@ -34,9 +34,9 @@ class MemoryRetainerNode : public v8::EmbedderGraph::Node {
}

inline MemoryRetainerNode(MemoryTracker* tracker,
const char* name,
size_t size,
bool is_root_node = false)
const char* name,
size_t size,
bool is_root_node = false)
: retainer_(nullptr) {
name_ = name;
size_ = size;
Expand Down