[v12.x backport] http2: check write not scheduled in scope destructor#36355
Closed
davedoesdev wants to merge 1 commit intonodejs:v12.x-stagingfrom
davedoesdev:backport-33156-to-v12.x
Closed
[v12.x backport] http2: check write not scheduled in scope destructor#36355davedoesdev wants to merge 1 commit intonodejs:v12.x-stagingfrom davedoesdev:backport-33156-to-v12.x
davedoesdev wants to merge 1 commit intonodejs:v12.x-stagingfrom
davedoesdev:backport-33156-to-v12.x
Conversation
nodejs-github-bot
added
c++
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36355 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
approved these changes
Dec 3, 2020
Contributor
Author
|
Is this waiting for the next v12 release? |
BethGriggs
approved these changes
Feb 8, 2021
Collaborator
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2021
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36355 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 10, 2021
Fixes: #33156 PR-URL: #36241 Backport-PR-URL: #36355 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
richardlau
force-pushed
the
v12.x-staging
branch
from
0692611 to
6cef0e3
Compare
Collaborator
Collaborator
Member
richardlau
force-pushed
the
v12.x-staging
branch
from
61c274b to
6ac4a9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #33156
PR-URL: #36241
Reviewed-By: Matteo Collina [email protected]
Reviewed-By: Rich Trott [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes