LGTM, this retains the same functionality since EventEmitter catches it and also throws.

cc @jasnell who added it in #3090

replaces #3618

CI: https://ci.nodejs.org/job/node-test-pull-request/660/

https://ci.nodejs.org/job/node-test-binary-windows/185/RUN_SUBSET=2,VS_VERSION=vs2013,label=win2008r2/tapTestReport/test.tap-11/

not ok 11 test-child-process-fork-regr-gh-2847.js
# events.js:141
# throw er; // Unhandled 'error' event
# ^
# 
# Error: read ECONNRESET
# at exports._errnoException (util.js:860:11)
# at TCP.onread (net.js:544:26)

Looks unrelated but confirmation would be great, I'm not familiar with that test.

LGTM

should I close this one #3618 ?

@Fishrock123 I've seen that elsewhere recently too. Could you open a new issue?

@aks- Yes you can close the older PR. :)

Edit: I'll just do it when I merge this.

@aks- Your git is setup to sign commits as aks- <[email protected]>, usually we use non-usernames there, if you would like that and/or be comfortable with it. :)

It's not required, so if you are fine with it being aks- just let me know.,

You can change it by doing:

git config --global user.name "Jeremiah Senkpiel"

git commit --amend --reset-author --no-edit

And force pushing the new commit back up here. :)

LGTM

@Fishrock123 done :)

Thanks, landed in 8625a38 \o/

this was originally proposed to roll back changes found in 0094a8d

The associated PR #3090 is semver-major. As such I am removing the label for lts watch.

@jasnell removing lts-watch as per previous comment. These changes only apply to master... not v4.x-staging