Skip to content

n-api: unlink reference during its destructor #35933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 2 commits into from
Closed

n-api: unlink reference during its destructor #35933

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd7d042
n-api: unlink reference during its destructor
Nov 2, 2020
b2cf693
fixup! make the destructor virtual
Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! make the destructor virtual
  • Loading branch information
Gabriel Schulhof committed Nov 3, 2020
commit b2cf693bbfd66368a266a7545ae205c0881415dc
2 changes: 1 addition & 1 deletion src/js_native_api_v8.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ class RefBase : protected Finalizer, RefTracker {
finalize_hint);
}

~RefBase() { Unlink(); }
virtual ~RefBase() { Unlink(); }

inline void* Data() {
return _finalize_data;
Expand Down