Skip to content

module: refactor to use iterable-weak-map #35915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcoe wants to merge 10 commits into from
Closed

module: refactor to use iterable-weak-map #35915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
414ea74
module: refactor to use iterable-weak-map
Nov 3, 2020
3ca2431
test: add test for iterable-source-map fix
Nov 3, 2020
9d5d45d
build: fix naming
Nov 3, 2020
e156fa1
Update test/parallel/test-source-map-enable.js
Nov 3, 2020
5a80dfd
test: add tests for iterable-weak-map
Nov 4, 2020
46e0bba
chore: address review
Nov 4, 2020
6434455
fix: switch from name to id
Nov 4, 2020
0b30bc2
chore: address code review
Nov 5, 2020
e994511
chore: address code review
Nov 5, 2020
f1d088a
chore: address code review
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: address review
  • Loading branch information
bcoe committed Nov 5, 2020
commit 46e0bbaad381fd519f57792b2f19dd14eadcbd61
3 changes: 3 additions & 0 deletions doc/api/module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,10 @@ import { findSourceMap, SourceMap } from 'module';
const { findSourceMap, SourceMap } = require('module');
```

<!-- Anchors to make sure old links find a target -->
<a name="module_module_findsourcemap_path_error"></a>
### `module.findSourceMap(path)`

<!-- YAML
added:
- v13.7.0
Expand Down
3 changes: 1 addition & 2 deletions lib/internal/util/iterable_weak_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ class IterableWeakMap {
}

get(key) {
const entry = this.#weakMap.get(key);
return entry && entry.value;
return this.#weakMap.get(key)?.value;
}

delete(key) {
Expand Down