Skip to content

events: support abortsignal in ee.on #35877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 4 commits into from
Closed

events: support abortsignal in ee.on #35877

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
866e7af
events: support abortsignal in ee.on
benjamingr Oct 31, 2020
c9e2a82
fixup! add test
benjamingr Oct 31, 2020
9622746
fixup! add test + guard for undefined
benjamingr Oct 31, 2020
c58781e
Merge branch 'master' into event-emitter-abortsignal
benjamingr Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into event-emitter-abortsignal
  • Loading branch information
@benjamingr
benjamingr authored Jan 17, 2022
commit c58781eb8a6c248fa5e954cb9a3d914de0c3bfea
3 changes: 3 additions & 0 deletions doc/api/events.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ changes:
The `'removeListener'` event is emitted _after_ the `listener` is removed.

### `emitter.addListener(eventName, listener [,options])`

<!-- YAML
added: v0.1.26
-->
Expand Down Expand Up @@ -455,6 +456,7 @@ added: v10.0.0
Alias for [`emitter.removeListener()`][].

### `emitter.on(eventName, listener[, options])`

<!-- YAML
added: v0.1.101
-->
Expand Down Expand Up @@ -543,6 +545,7 @@ myEE.emit('foo');
```

### `emitter.prependListener(eventName, listener [,options])`

<!-- YAML
added: v6.0.0
-->
Expand Down
6 changes: 6 additions & 0 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,12 @@ function _addListener(target, type, listener, prepend, options) {
return target;
}

/**
* Adds a listener to the event emitter.
* @param {string | symbol} type
* @param {Function} listener
* @returns {EventEmitter}
*/
EventEmitter.prototype.addListener =
function addListener(type, listener, options) {
return _addListener(this, type, listener, false, options);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.