Skip to content

add proxy handler "has" for "http2.Http2ServerResponse.socket" and "http2.Http2ServerRequest.socket" #35197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masx200 wants to merge 17 commits into from
Closed

add proxy handler "has" for "http2.Http2ServerResponse.socket" and "http2.Http2ServerRequest.socket" #35197

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
dd8afa3
Update compat.js
masx200 Sep 14, 2020
fad3ea4
Create test-for-pull-35197.js
masx200 Sep 14, 2020
4ef108c
Update compat.js
masx200 Sep 14, 2020
33d14d2
Update test-for-pull-35197.js
masx200 Sep 14, 2020
f8db9cd
Update test-for-pull-35197.js
masx200 Sep 14, 2020
40e47a7
Update test-for-pull-35197.js
masx200 Sep 14, 2020
4def244
Update compat.js
masx200 Sep 15, 2020
4f0b74a
Update test-for-pull-35197.js
masx200 Sep 15, 2020
832d616
Update test-for-pull-35197.js
masx200 Sep 15, 2020
68268bf
Update test-for-pull-35197.js
masx200 Sep 15, 2020
e634e59
Update compat.js
masx200 Sep 15, 2020
ccfccf1
Update test-for-pull-35197.js
masx200 Sep 15, 2020
6a67797
Update test-for-pull-35197.js
masx200 Sep 15, 2020
362a628
fixup! Update test-for-pull-35197.js
Trott Sep 18, 2020
734fa63
fixup! fixup! Update test-for-pull-35197.js
Trott Sep 18, 2020
19b0951
Update lib/internal/http2/compat.js
masx200 Sep 18, 2020
8259db5
Rename test-for-pull-35197.js to test-http2-socket-proxy-handler-for-…
masx200 Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,13 @@ function resumeStream(stream) {
}

const proxySocketHandler = {


has(stream, prop) {
const ref = stream.session !== undefined ? stream.session[kSocket] : stream;
return (prop in stream ) || (prop in ref);
},

get(stream, prop) {
switch (prop) {
case 'on':
Expand Down
36 changes: 36 additions & 0 deletions test/parallel/test-for-pull-35197.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');
const assert = require('assert');
const http2 = require('http2');
if (!common.hasCrypto){
common.skip('missing crypto');

}
const serverOptions = {
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem')
};
const server = http2.createSecureServer(serverOptions, common.mustCall((req, res) => {
const request = req;
assert(true === request.socket.encrypted);
assert('encrypted' in request.socket);
res.end();
}));
server.listen(common.mustCall(() => {
const port = server.address().port;
const client = http2.connect('https://localhost:' + port, {
ca: fixtures.readKey('agent1-cert.pem'),
rejectUnauthorized: false
});
const req = client.request({});
req.on('response', common.mustCall((headers, flags) => {
console.log(headers);
server.close(common.mustCall(() => {
}));
}));
req.on('end', common.mustCall(() => {
client.close();
}));
req.end();
}));