Skip to content

doc,lib: remove unused error code#34792

Closed
Trott wants to merge 0 commit intonodejs:masterfrom
Trott:unused-error
Closed

doc,lib: remove unused error code#34792
Trott wants to merge 0 commit intonodejs:masterfrom
Trott:unused-error

Conversation

@Trott
Copy link
Member

@Trott Trott commented Aug 15, 2020 •
edited
Loading

As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Aug 15, 2020
@richardlau
Copy link
Member

richardlau commented Aug 15, 2020

As best as I can tell, ERR_V8BREAKIDICATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

FWIW it looks like it was removed in 668ad44 but put back into the list of errors in e9358af. Both commits landed within a few days of each other so the reintroduction was probably unintentional.

Also just spotted that "ERR_V8BREAKITERATOR" is mispelled in the commit message.

@Trott
Copy link
Member Author

Trott commented Aug 15, 2020

Also just spotted that "ERR_V8BREAKITERATOR" is mispelled in the commit message.

Fixed. Thanks!

@Trott Trott force-pushed the unused-error branch 2 times, most recently from 86fc29f to 459521b Compare August 16, 2020 00:00
@Trott Trott changed the title doc: remove unused error code doc,lib: remove unused error code Aug 16, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2020
@richardlau
Copy link
Member

richardlau commented Aug 16, 2020

Also just spotted that "ERR_V8BREAKITERATOR" is mispelled in the commit message.

Fixed. Thanks!

@Trott The error code is ERR_V8BREAKITERATOR, not ERR_V8BREAKINDICATOR 😀.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32797/

@Trott
Copy link
Member Author

Trott commented Aug 16, 2020

Also just spotted that "ERR_V8BREAKITERATOR" is mispelled in the commit message.

Fixed. Thanks!

@Trott The error code is ERR_V8BREAKITERATOR, not ERR_V8BREAKINDICATOR 😀.

I guess "Fixed" implies "Fixed correctly" so I better go fix it again....

@Trott
Copy link
Member Author

Trott commented Aug 16, 2020

OK, commit message error is now fixed correctly, I think and hope.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32798/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 16, 2020
@nodejs nodejs deleted a comment from ayed42 Aug 16, 2020
@jasnell
Copy link
Member

jasnell commented Aug 17, 2020

fast-track?

@jasnell jasnell added the fast-track PRs that do not need to wait for 72 hours to land. label Aug 17, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32818/

Trott added a commit that referenced this pull request Aug 18, 2020
@Trott
doc,lib: remove unused error code
15fdd98 
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

PR-URL: #34792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott
Copy link
Member Author

Trott commented Aug 18, 2020

Landed in 15fdd98

@Trott Trott closed this Aug 18, 2020
@Trott Trott deleted the unused-error branch August 18, 2020 05:06
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
doc,lib: remove unused error code
ccfc0a6 
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

PR-URL: #34792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
doc,lib: remove unused error code
7d0970c 
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

PR-URL: #34792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc,lib: remove unused error code
b285486 
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

PR-URL: #34792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
doc,lib: remove unused error code
05dae02 
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our
code base and dependencies. Move to legacy errors.

PR-URL: #34792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @richardlau @nodejs-github-bot @jasnell @lpinca @tniessen @BridgeAR