Skip to content

test: skip node-api/test_worker_terminate_finalization #34732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

test: skip node-api/test_worker_terminate_finalization #34732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: skip node-api/test_worker_terminate_finalization 
The test fails under ASAN/valgrind. Since it has not been working
properly until today anyway, skip it.

Refs: #34731
  • Loading branch information
@addaleax
addaleax committed Aug 11, 2020
commit 1078495e9e0b71fc0c44e161e58b70f0cfdfcbcd
5 changes: 5 additions & 0 deletions test/node-api/test_worker_terminate_finalization/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
'use strict';
const common = require('../../common');

// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
// Refs: https://github.com/nodejs/node/issues/34731
common.skip('Reference management in N-API leaks memory');

const { Worker, isMainThread } = require('worker_threads');

if (isMainThread) {
Expand Down