Skip to content

http2: allow Host in HTTP/2 requests #34664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mildsunrise wants to merge 3 commits into from
Closed

http2: allow Host in HTTP/2 requests #34664

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
014c725
http2: allow Host in HTTP/2 requests
mildsunrise Aug 7, 2020
fe83df7
typos
mildsunrise Aug 7, 2020
f96d134
improvements in docs
mildsunrise Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
improvements in docs
  • Loading branch information
@mildsunrise
mildsunrise committed Aug 11, 2020
commit f96d134e64a2ffd75b2ef7ed5f437b9c5e019b45
24 changes: 9 additions & 15 deletions doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/34664
description: Requests with the `host` header (with or without
`:authority`) can now be sent / received.
`:authority`) can now be sent/received.
- version: v10.10.0
pr-url: https://github.com/nodejs/node/pull/22466
description: HTTP/2 is now Stable. Previously, it had been Experimental.
Expand Down Expand Up @@ -2914,7 +2914,8 @@ added: v8.4.0

The request authority pseudo header field. Because HTTP/2 allows requests
to set either `:authority` or `host`, this value is derived from
`req.headers[':authority']` if present, `req.headers['host']` otherwise.
`req.headers[':authority']` if present. Otherwise, it is derived from
`req.headers['host']`.

#### `request.complete`
<!-- YAML
Expand Down Expand Up @@ -3716,21 +3717,14 @@ following additional properties:
## Note on `:authority` and `host`

HTTP/2 requires requests to have either the `:authority` pseudo-header
or the `host` header. Using `:authority` should be preferred when
constructing an HTTP/2 request directly, and `host` should be
preferred when converting from HTTP/1 (in proxies, for instance).

Historically, Node.js required all requests to have the `:authority`
pseudo-header and rejected requests with the `host` header present.
This has been corrected; the `host` header is now allowed, and the
only requirement is for either `host` or `:authority` to be
present (or both). The same validations from `:authority` extend
to `host`.
or the `host` header. Prefer `:authority` when constructing an HTTP/2
request directly, and `host` when converting from HTTP/1 (in proxies,
for instance).

The compatibility API falls back to `host` if `:authority` is not
present, see [`request.authority`][]. However, if you don't use the
compatibility API (or use `req.headers` directly), you need to
implement any fall-back behaviour yourself.
present. See [`request.authority`][] for more information. However,
if you don't use the compatibility API (or use `req.headers` directly),
you need to implement any fall-back behaviour yourself.

[ALPN Protocol ID]: https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids
[ALPN negotiation]: #http2_alpn_negotiation
Expand Down