Skip to content

Comments

[v14.x backport] util: print External address from inspect#34583

Closed
rosaxxny wants to merge 1 commit intonodejs:v14.x-stagingfrom
rosaxxny:backport-34398-to-v14.x
Closed

[v14.x backport] util: print External address from inspect#34583
rosaxxny wants to merge 1 commit intonodejs:v14.x-stagingfrom
rosaxxny:backport-34398-to-v14.x

Conversation

@rosaxxny
Copy link
Contributor

Fixes: #28250

PR-URL: #34398
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Gus Caplan [email protected]
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Tobias Nießen [email protected]

Fixes: nodejs#28250

PR-URL: nodejs#34398
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. v14.x labels Jul 31, 2020
@rosaxxny rosaxxny changed the title util: print External address from inspect [v14.x backport] util: print External address from inspect Jul 31, 2020
@nodejs-github-bot
Copy link
Collaborator

danielleadams pushed a commit that referenced this pull request Aug 4, 2020
Fixes: #28250

PR-URL: #34398
Backport-PR-URL: #34583
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams
Copy link
Contributor

Landed in f46649b

addaleax pushed a commit that referenced this pull request Sep 22, 2020
Fixes: #28250

PR-URL: #34398
Backport-PR-URL: #34583
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Fixes: #28250

PR-URL: #34398
Backport-PR-URL: #34583
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants