Skip to content

cluster: make kill to be just process.kill #34312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 13 commits into from
Feb 4, 2022
Merged

cluster: make kill to be just process.kill #34312

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b0c41ed
cluster: make kill to be just process.kill
Jul 11, 2020
4fb861a
cluster: make kill to be just process.kill
Jul 11, 2020
fba0315
Remove from README
Jul 11, 2020
c1dc038
Improve test-cluster-worker-kill-signal readbility
Jul 11, 2020
60d10ca
Addressing @mscdex comments
Jul 11, 2020
13902f2
Moved the assertion to the when the cluster is exiting
Jul 11, 2020
9af5aca
Adding numberOfWorkers assertion
Jul 11, 2020
84b8cf0
Addressing @bnoordhuis comments
Jul 12, 2020
7de8040
Make the assersion in the test and not in the end
Jul 12, 2020
7f93807
Align terminology
Mar 18, 2021
616a414
Fix markdown lint
Mar 18, 2021
080d8d4
Re-fix markdown lint
Mar 18, 2021
99b7db7
Revert README.md
Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix markdown lint
  • Loading branch information
Bar Admoni committed Feb 4, 2022
commit 616a414beda50aa2daf11b4beff7e179d4fabf6f
6 changes: 3 additions & 3 deletions doc/api/cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,9 @@ added: v0.9.12
* `signal` {string} Name of the kill signal to send to the worker
process. **Default:** `'SIGTERM'`

This function will kill the worker. In the primary worker, it does this by disconnecting
the `worker.process`, and once disconnected, killing with `signal`. In the
worker, it does it by killing the process with `signal`.
This function will kill the worker. In the primary worker, it does this by
disconnecting the `worker.process`, and once disconnected, killing with
`signal`. In the worker, it does it by killing the process with `signal`.

The `kill()` function kills the worker process without waiting for a graceful
disconnect, it has the same behavior as `worker.process.kill()`.
Expand Down