You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Besides, I notice that lib/lint-md.js is using different EOF, should they be unified into one format? If not, developer can't directly use VSCode or WebStorm modify this file, because they will unify EOF while saving. Vim will not change.
lint-md.js is generated so should not be edited. Something should probably be done to the process so that it ends up with the same line and file endings as everything else. The generation routine can be found in the Makefile's lint-md-rollup task. The key bit there is the build-node task in the package.json file in tools/node-lint-md-cli-rollup.
Less sure about punycode.js. It used to be from an upstream source but I think we've modified it and it's no longer maintained upstream. Someone want to confirm that?
For lint-md.js, you can grep through node_modules dependencies to see where to upstream the fixes. For example, the regxep typo is in the debug module. The repo is here and the typo in that repo is here.
thanks @Trott 's review, I update this branch and push a new branch ( #34233 ) that can add a banner to lint-md.js to hint others don't change this file directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolsIssues and PRs related to the tools directory.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the following files JSDoc typo
UPDATE
will not be changed by this branchtools/lint-md.jsChecklist