Skip to content

module: package "imports" field #34117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 10 commits into from
Closed

module: package "imports" field #34117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d9f7c01
module: package "imports" field
guybedford Jun 28, 2020
5875d53
docs feedback
guybedford Jul 1, 2020
105b7f2
Apply suggestions from code review
guybedford Jul 1, 2020
8fe68f7
Apply suggestions from code review
guybedford Jul 2, 2020
1dc83f5
percent-encoded target test
guybedford Jul 4, 2020
ceffe4c
fixup cycle bug
guybedford Jul 4, 2020
2570191
unify invalid specifier check
guybedford Jul 9, 2020
ec4b7a4
Update lib/internal/modules/cjs/loader.js
guybedford Jul 9, 2020
eb34788
Update lib/internal/modules/esm/resolve.js
guybedford Jul 9, 2020
6a69697
add RegExpPrototypeTest
guybedford Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Jan Olaf Krems <[email protected]>
  • Loading branch information
@guybedford @hybrist
guybedford and hybrist committed Jul 4, 2020
commit 105b7f2b033c4ba6062cfbf96c8386de7ea3b3e6
1 change: 1 addition & 0 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,7 @@ Module._load = function(request, parent, isMain) {
return module.exports;
};

// TODO: Use this set when resolving pkg#exports conditions.
const cjsConditions = new Set(['require', 'node']);
Module._resolveFilename = function(request, parent, isMain, options) {
if (NativeModule.canBeRequiredByUsers(request)) {
Expand Down
4 changes: 2 additions & 2 deletions lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function getPackageConfig(path) {
name,
type,
exports,
imports
imports,
};
packageJSONCache.set(path, packageConfig);
return packageConfig;
Expand Down Expand Up @@ -156,7 +156,7 @@ function getPackageScopeConfig(resolved, base) {
name: undefined,
type: 'none',
exports: undefined,
imports: undefined
imports: undefined,
};
packageJSONCache.set(packageJSONPath, packageConfig);
return packageConfig;
Expand Down
1 change: 0 additions & 1 deletion test/es-module/test-esm-exports.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ import fromInside from '../fixtures/node_modules/pkgexports/lib/hole.js';

// The use of %2F escapes in paths fails loading
loadFixture('pkgexports/sub/..%2F..%2Fbar.js').catch(mustCall((err) => {
console.log(err);
strictEqual(err.code, 'ERR_INVALID_MODULE_SPECIFIER');
}));

Expand Down