Skip to content

events: improve listeners() performance#33863

Closed
mscdex wants to merge 1 commit intonodejs:masterfrom
mscdex:events-listeners-perf
Closed

events: improve listeners() performance#33863
mscdex wants to merge 1 commit intonodejs:masterfrom
mscdex:events-listeners-perf

Conversation

@mscdex
Copy link
Contributor

@mscdex mscdex commented Jun 13, 2020

Benchmark results (keep in mind listeners is always implicitly multiplied by 2 by the benchmark):

                                                             confidence improvement accuracy (*)   (**)  (***)
 events/ee-listeners.js raw='false' listeners=1 n=5000000                  -0.96 %       ±2.89% ±3.85% ±5.03%
 events/ee-listeners.js raw='false' listeners=10 n=5000000         ***      7.71 %       ±1.48% ±1.98% ±2.61%
 events/ee-listeners.js raw='false' listeners=100 n=5000000        ***     35.04 %       ±0.89% ±1.19% ±1.58%
 events/ee-listeners.js raw='false' listeners=2 n=5000000          ***     20.62 %       ±1.41% ±1.89% ±2.47%
 events/ee-listeners.js raw='false' listeners=5 n=5000000          ***     27.57 %       ±0.80% ±1.07% ±1.40%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js. labels Jun 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31853/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 16, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 16, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31893/

jasnell pushed a commit that referenced this pull request Jun 17, 2020
@mscdex @jasnell
events: improve listeners() performance
a4f3206 
PR-URL: #33863
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@jasnell
Copy link
Member

jasnell commented Jun 17, 2020

Landed in a4f3206

@jasnell jasnell closed this Jun 17, 2020
@github-actions github-actions bot mentioned this pull request Jun 18, 2020
Open
18 tasks
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@mscdex @codebytere
events: improve listeners() performance
667195e 
PR-URL: #33863
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 19, 2020
Open
36 tasks
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@mscdex @codebytere
events: improve listeners() performance
7cbbd8f 
PR-URL: #33863
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mscdex @addaleax
events: improve listeners() performance
ff7fbc3 
PR-URL: #33863
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@ronag ronag ronag approved these changes

@Flarna Flarna Flarna approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

+1 more reviewer

@MrHeer MrHeer MrHeer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@mscdex @nodejs-github-bot @jasnell @addaleax @lpinca @ronag @MrHeer @Flarna @ZYSzys