Skip to content

src: small modification to NgHeader #33289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 2 commits into from
Closed

src: small modification to NgHeader #33289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37c4760
src: small modification to NgHeader
jasnell May 7, 2020
a51e057
fixup! src: small modification to NgHeader
jasnell May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: small modification to NgHeader
  • Loading branch information
@jasnell
jasnell committed May 7, 2020
commit a51e0573c8ac1442247c21dc85ec0651145d6f8c
2 changes: 1 addition & 1 deletion src/node_http_common-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ size_t GetServerMaxHeaderPairs(size_t max_header_pairs) {
}

template <typename allocator_t>
std::string NgHeaderImpl<allocator_t>::ToString() const {
std::string NgHeaderBase<allocator_t>::ToString() const {
std::string ret = name();
ret += " = ";
ret += value();
Expand Down
4 changes: 2 additions & 2 deletions src/node_http_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ class NgRcBufPointer : public MemoryRetainer {
};

template <typename allocator_t>
struct NgHeaderImpl : public MemoryRetainer {
struct NgHeaderBase : public MemoryRetainer {
virtual v8::MaybeLocal<v8::String> GetName(allocator_t* allocator) const = 0;
virtual v8::MaybeLocal<v8::String> GetValue(allocator_t* allocator) const = 0;
virtual std::string name() const = 0;
Expand All @@ -471,7 +471,7 @@ struct NgHeaderImpl : public MemoryRetainer {
// memory tracking, and implementation of static utility functions.
// See Http2HeaderTraits in node_http2.h for an example.
template <typename T>
class NgHeader : public NgHeaderImpl<typename T::allocator_t> {
class NgHeader final : public NgHeaderBase<typename T::allocator_t> {
public:
typedef typename T::rcbufferpointer_t rcbufferpointer_t;
typedef typename T::rcbufferpointer_t::rcbuf_t rcbuf_t;
Expand Down