Skip to content

test: skip memory usage tests when ASAN is enabled #33129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

test: skip memory usage tests when ASAN is enabled #33129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: skip memory usage tests when ASAN is enabled 
Running tests with an ASAN build leads to increased memory usage,
rendering the memory usage assumptions in the test invalid.

Refs: #32776 (comment)
  • Loading branch information
@addaleax
addaleax committed Apr 28, 2020
commit eb783385d3b204b225e32db968417e3bd7035974
2 changes: 2 additions & 0 deletions test/parallel/test-crypto-dh-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
if (process.config.variables.asan)
common.skip('ASAN messes with memory measurements');

const assert = require('assert');
const crypto = require('crypto');
Expand Down
3 changes: 3 additions & 0 deletions test/sequential/test-net-bytes-per-incoming-chunk-overhead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
'use strict';

const common = require('../common');
if (process.config.variables.asan)
common.skip('ASAN messes with memory measurements');

const assert = require('assert');
const net = require('net');

Expand Down