Skip to content

doc: elevate diagnostic report to tier1 #32732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gireeshpunathil wants to merge 2 commits into from
Closed

doc: elevate diagnostic report to tier1 #32732

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df6af59
doc: elevate diagnostic report to tier1
gireeshpunathil Mar 25, 2020
1039e50
fixup: revert node-report tier status
gireeshpunathil Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/guides/diagnostic-tooling-support-tiers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ The tools are currently assigned to Tiers as follows:

| Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |
|-----------|---------------------------|-------------------------------|-------------------------|-------------|
| | | | | |
| FFDC | diagnostic report | Yes | Yes | 1 |
| | | | | |

## Tier 2

Expand Down Expand Up @@ -123,7 +124,6 @@ The tools are currently assigned to Tiers as follows:

| Tool Type | Tool/API Name | Regular Testing in Node.js CI | Integrated with Node.js | Target Tier |
|-----------|---------------------------|-------------------------------|-------------------------|-------------|
| FFDC | node-report | No | No | 1 |
Copy link
Member

@richardlau richardlau Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather either keep the npm node-report module as unclassified or moved to tier 4.

Copy link
Member

@mhdawson mhdawson Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move it to tier unclassified.

Copy link
Member Author

@gireeshpunathil gireeshpunathil Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau @mhdawson - reverted the case of node-report, PTAL!

| Memory | mdb_V8 | No | No | 4 |
| Memory | node-heapdump | No | No | 2 |
| Memory | V8 heap profiler | No | Yes | 1 |
Expand Down