-
-
Notifications
You must be signed in to change notification settings - Fork 35k
doc: additional note in README(.md) informing users that it is advise… #32655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
haqer1
wants to merge
4
commits into
nodejs:master
from
haqer1:signing-key-fixup-alternative-approach-2-part-2-alternative
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9bd6618
doc: additional note in README(.md) informing users that it is advise…
haqer1 2e103ed
doc: apply suggestion from code review
haqer1 945cce5
doc: additional note in README(.md) informing users that it is advise…
haqer1 69d81a9
doc: additional note in README(.md) informing users that it is advise…
haqer1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
doc: additional note in README(.md) informing users that it is advise…
…d to import the full set of trusted release keys (rather than an individual key) Additional README.md update Fixes: #32559
- Loading branch information
commit 9bd661815e56e75aa8eb84a5cfe625bb80c5a2e7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -565,7 +565,9 @@ GPG keys used to sign Node.js releases: | |
| * **Shelley Vohr** <[email protected]> | ||
| `B9E2F5981AA6E0CD28160D9FF13993A75599653C` | ||
|
|
||
| To import the full set of trusted release keys: | ||
| To avoid nuances involved in verification of a sub-key possibly used to sign a | ||
| release, it is advised to import the full set of trusted release keys (rather | ||
| than an individual key used to sign a release): | ||
|
|
||
| ```shell | ||
| gpg --keyserver pool.sks-keyservers.net --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.