test: remove non required console.log#32541
Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Collaborator
ZYSzys
approved these changes
Mar 29, 2020
cjihrig
approved these changes
Mar 29, 2020
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. Alternatively, you could change the console.log() to util.debuglog().
jasnell
approved these changes
Mar 29, 2020
Member
If you wanted to do this, include |
3 tasks
Member
Author
Something like this? I think this test does not require logging very much. |
Trott
approved these changes
Mar 30, 2020
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM.
Commit message suggestion:
test: remove unnecessary console.log() calls
juanarbol
force-pushed
the
juanarbol/remove-console-log
branch
from
9550ead to
c21e9b9
Compare
Member
Author
Commit reword is done! Thank you! |
Collaborator
ZYSzys
added
the
author ready
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
PR-URL: #32550 Refs: #32541 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Member
|
Landed in 9a914ff |
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
PR-URL: #32541 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
PR-URL: #32550 Refs: #32541 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
PR-URL: #32541 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32550 Refs: #32541 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32541 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32550 Refs: #32541 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32541 Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes