Skip to content

src: split out per-binding state from Environment #32538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 15 commits into from
Closed

src: split out per-binding state from Environment #32538

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4fba668
src: make creating per-binding data structures easier
addaleax Mar 5, 2019
824f84e
src: move HTTP/2 state out of Environment
addaleax Mar 5, 2019
9f0f5f9
src: move v8 stats buffers out of Environment
addaleax Mar 5, 2019
6da22d8
src: move http parser state out of Environment
addaleax Mar 28, 2020
ad65335
src: move fs state out of Environment
addaleax Mar 5, 2019
610dfe5
src,doc: add documentation for per-binding state pattern
addaleax Mar 28, 2020
9222827
fixup! src,doc: add documentation for per-binding state pattern
addaleax Mar 29, 2020
a68f057
fixup! src: make creating per-binding data structures easier
addaleax Mar 29, 2020
d9e7d38
fixup! src: move fs state out of Environment
addaleax Mar 29, 2020
5a2317d
fixup! src: move v8 stats buffers out of Environment
addaleax Mar 29, 2020
38e471c
fixup! src: move HTTP/2 state out of Environment
addaleax Mar 29, 2020
0273dbf
fixup! src: move http parser state out of Environment
addaleax Mar 29, 2020
72d24ee
fixup! src: move v8 stats buffers out of Environment
addaleax Mar 30, 2020
54324b6
fixup! fixup! src: move http parser state out of Environment
addaleax Mar 30, 2020
330e24b
fixup! src: move fs state out of Environment
addaleax Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: move fs state out of Environment
  • Loading branch information
@addaleax
addaleax committed Apr 2, 2020
commit 330e24bbb5f57094299e11293265df7aef3cff7e
2 changes: 1 addition & 1 deletion src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,7 +2015,7 @@ static void ReadBuffers(const FunctionCallbackInfo<Value>& args) {
iovs[i] = uv_buf_init(Buffer::Data(buffer), Buffer::Length(buffer));
}

FSReqBase* req_wrap_async = GetReqWrap(env, args[3]);
FSReqBase* req_wrap_async = GetReqWrap(args, 3);
if (req_wrap_async != nullptr) { // readBuffers(fd, buffers, pos, req)
AsyncCall(env, req_wrap_async, args, "read", UTF8, AfterInteger,
uv_fs_read, fd, *iovs, iovs.length(), pos);
Expand Down