Skip to content

n-api: fix comment on expected N-API version #32236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 1 commit into from
Closed

n-api: fix comment on expected N-API version #32236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
n-api: fix comment on expected N-API version 
Remove the comment about the expected version so
that it does not get out of sync. The code shows
the expected version anyway.

Signed-off-by: Michael Dawson <[email protected]>
  • Loading branch information
@mhdawson
mhdawson committed Mar 12, 2020
commit bc570c1ff57aaa9495904748e3e750fa6fd46e29
2 changes: 1 addition & 1 deletion test/js-native-api/test_general/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ assert.strictEqual(test_general.testGetPrototype(extendedObject),
assert.notStrictEqual(test_general.testGetPrototype(baseObject),
test_general.testGetPrototype(extendedObject));

// Test version management functions. The expected version is currently 4.
// Test version management functions
assert.strictEqual(test_general.testGetVersion(), 6);

[
Expand Down