Skip to content

report: handle on-fatalerror better #32207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 4 commits into from
Closed

report: handle on-fatalerror better #32207

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
175c2e7
report: handle on-fatalerror better
HarshithaKP Mar 16, 2020
7915e7e
fixup: address review comment
HarshithaKP Mar 16, 2020
3bf8c60
fixup: fix linter error
HarshithaKP Mar 16, 2020
7dbc5de
fixup: fix linter error
HarshithaKP Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: address review comment
  • Loading branch information
@HarshithaKP
HarshithaKP committed Mar 24, 2020
commit 7915e7eb4665df8965d4bbb3e0766b1abb8639af
3 changes: 2 additions & 1 deletion test/report/test-report-fatal-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ if (process.argv[2] === 'child') {
assert.strictEqual(reports.length, 1);
const report = reports[0];
helper.validate(report);


// Verify that reports are not created on fatal error by default.
args = ['--max-old-space-size=20',
Copy link
Contributor

@cjihrig cjihrig Mar 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here. Something along the lines of // Verify that reports are not created on fatal error by default.

Copy link
Member Author

@HarshithaKP HarshithaKP Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggested comment in test case. PTAL.

__filename,
'child'];
Expand Down