Skip to content

build: add build from tarball #32129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkleinsc wants to merge 4 commits into from
Closed

build: add build from tarball #32129

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78658af
build: add build from tarball
Mar 6, 2020
bbdf382
test: use symlinks to copy shells
Apr 7, 2020
67d4d2b
Use Python 2.7 for Windows testing
Apr 7, 2020
f5dc4d2
Move built release to checkout dir
Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use symlinks to copy shells 
Git for Windows includes C:\Program Files\Git\bin\bash.exe which spawns ..\usr\bin\bash.exe so copying that executable won't work.  However if a symlink is used to test paths with spaces this executable will still work.
  • Loading branch information
John Kleinschmidt committed Apr 9, 2020
commit bbdf382800a4f7a8e676aa188af358085928a7af
4 changes: 2 additions & 2 deletions test/parallel/test-child-process-exec-any-shells-windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ const test = (shell) => {
}));
};
const testCopy = (shellName, shellPath) => {
// Copy the executable to a path with spaces, to ensure there are no issues
// Symlink the executable to a path with spaces, to ensure there are no issues
// related to quoting of argv0
const copyPath = `${tmpPath}\\${shellName}`;
fs.copyFileSync(shellPath, copyPath);
fs.symlinkSync(shellPath, copyPath);
test(copyPath);
};

Expand Down