Skip to content

src,http2: introduce node_http_common #32069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

src,http2: introduce node_http_common #32069

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d95001
src,http2: introduce node_http_common
jasnell Mar 3, 2020
d69f2b4
[Squash] nits
jasnell Mar 4, 2020
e6bc482
fixup! [Squash] nits
jasnell Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Squash] nits 
Co-Authored-By: Anna Henningsen <[email protected]>
  • Loading branch information
@jasnell @addaleax
jasnell and addaleax authored Mar 4, 2020
commit d69f2b4e3ed4b6fb57de7723963f1917538ca3a2
4 changes: 2 additions & 2 deletions src/node_http2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2188,8 +2188,8 @@ bool Http2Stream::AddHeader(nghttp2_rcbuf* name,
return false;
}

if (this->statistics_.first_header == 0)
this->statistics_.first_header = uv_hrtime();
if (statistics_.first_header == 0)
statistics_.first_header = uv_hrtime();

current_headers_.push_back(std::move(header));

Expand Down
2 changes: 1 addition & 1 deletion src/node_http_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ class NgRcBufPointer : public MemoryRetainer {
operator bool() const { return buf_ != nullptr; }
bool IsStatic() const { return T::is_static(buf_) != 0; }
void SetInternalizable() { internalizable_ = true; }
bool IsInternalizable() { return internalizable_; }
bool IsInternalizable() const { return internalizable_; }

static inline bool IsZeroLength(rcbuf_t* buf) {
if (buf == nullptr)
Expand Down