Skip to content

build: silence warnings from dependencies #31311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 2 commits into from
Closed

build: silence warnings from dependencies #31311

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f771f8d
build: silence c-ares Windows compiler warnings
richardlau Jan 11, 2020
307544c
build: silence OpenSSL Windows compiler warnings
richardlau Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: silence c-ares Windows compiler warnings 
Silence the following compiler warning on Windows:
`inet_addr': Use inet_pton() or InetPton() instead or define
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings`
  • Loading branch information
@richardlau
richardlau committed Jan 11, 2020
commit f771f8da12578d95b613724861d570850f960b14
5 changes: 4 additions & 1 deletion deps/cares/cares.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@
'defines': [ 'CARES_BUILDING_LIBRARY' ]
}],
[ 'OS=="win"', {
'defines': [ 'CARES_PULL_WS2TCPIP_H=1' ],
'defines': [
'CARES_PULL_WS2TCPIP_H=1',
'_WINSOCK_DEPRECATED_NO_WARNINGS',
],
'include_dirs': [ 'config/win32' ],
'sources': [
'src/config-win32.h',
Expand Down