stream: clean up definition using defineProperties#31236
Closed
antsmartian wants to merge 1 commit intonodejs:masterfrom
Closed
stream: clean up definition using defineProperties#31236antsmartian wants to merge 1 commit intonodejs:masterfrom
antsmartian wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
stream
mcollina
reviewed
Jan 7, 2020
BridgeAR
approved these changes
Jan 7, 2020
lpinca
approved these changes
Jan 7, 2020
BridgeAR
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Collaborator
Trott
approved these changes
Jan 9, 2020
Member
|
Landed in aff6fff |
Trott
pushed a commit
that referenced
this pull request
Jan 9, 2020
PR-URL: #31236 Refs: #31187 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31236 Refs: #31187 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
PR-URL: #31236 Refs: #31187 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final clean up for
Duplexstreams. Refs: #31187cc @nodejs/streams
make -j4 test(UNIX), orvcbuild test(Windows) passes