buffer: fix 6-byte writeUIntBE() range check#30459
Closed
mscdex wants to merge 1 commit intonodejs:masterfrom
Closed
buffer: fix 6-byte writeUIntBE() range check#30459mscdex wants to merge 1 commit intonodejs:masterfrom
mscdex wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
SimonSchick
approved these changes
Nov 13, 2019
addaleax
approved these changes
Nov 13, 2019
devnexen
approved these changes
Nov 13, 2019
cjihrig
approved these changes
Nov 13, 2019
addaleax
added
the
author ready
Collaborator
BridgeAR
approved these changes
Nov 13, 2019
Collaborator
jasnell
approved these changes
Nov 29, 2019
Collaborator
Trott
pushed a commit
that referenced
this pull request
Nov 30, 2019
Fixes: #30420 PR-URL: #30459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in c14c476 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Fixes: #30420 PR-URL: #30459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 5, 2019
Fixes: #30420 PR-URL: #30459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Fixes: #30420 PR-URL: #30459 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #30420
CI: https://ci.nodejs.org/job/node-test-pull-request/26530/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes