http2: use the latest settings#29780
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:fix-http2-settings
Closed
http2: use the latest settings#29780ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:fix-http2-settings
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:fix-http2-settings
Conversation
ZYSzys
commented
Sep 30, 2019
lib/internal/http2/core.js
Outdated
Member
Author
There was a problem hiding this comment.
If I'm not wrong, this line was deleted by accident in https://github.com/nodejs/node/pull/29122/files#diff-696b2cc418addca5f3fe5020058f8b15L416
/cc @addaleax
jasnell
approved these changes
Sep 30, 2019
lpinca
approved these changes
Sep 30, 2019
addaleax
approved these changes
Sep 30, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Yeah, I think this might have gotten lost during a rebase or something :/ Sorry!
cjihrig
approved these changes
Sep 30, 2019
BethGriggs
approved these changes
Oct 1, 2019
This comment has been minimized.
This comment has been minimized.
antsmartian
approved these changes
Oct 1, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
Oct 1, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Trott
pushed a commit
that referenced
this pull request
Oct 2, 2019
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
|
Landed in 6ba9471 |
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2019
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #29764
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes