Skip to content

tools: make code cache and snapshot deterministic #29142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bnoordhuis wants to merge 3 commits into from
Closed

tools: make code cache and snapshot deterministic #29142

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c2ba8d
tools: make code cache and snapshot deterministic
bnoordhuis Aug 15, 2019
4d9611c
fixup! add Math.random() regression test
bnoordhuis Aug 15, 2019
ed2c673
fixup! fix parallel/test-code-cache test
bnoordhuis Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix parallel/test-code-cache test
  • Loading branch information
@bnoordhuis
bnoordhuis committed Aug 15, 2019
commit ed2c673fb75bd617b43bfb8b0953b2dda48bfc75
3 changes: 3 additions & 0 deletions tools/code_cache/mkcodecache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ int main(int argc, char* argv[]) {
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);

// The command line flags are part of the code cache's checksum so reset
// --random_seed= to its default value before creating the code cache.
v8::V8::SetFlagsFromString("--random_seed=0");
std::string cache = CodeCacheBuilder::Generate(context);
out << cache;
out.close();
Expand Down