benchmark: swap var for let in path benchmarks

In benchmark path directory this changes for loops using var to let when it applies for consistency
nodejs · RamirezAlex · Jul 31, 2019 · Aug 1, 2019 · Aug 2, 2019 · Aug 2, 2019
commit 02e9a404126cfa62774b89bf8fcb01addd9ef17d
diff --git a/benchmark/path/basename-posix.js b/benchmark/path/basename-posix.js
@@ -27,7 +27,7 @@ function main({ n, pathext }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.basename(i % 3 === 0 ? `${pathext}${i}` : pathext, ext);
   }
   bench.end(n);

diff --git a/benchmark/path/basename-win32.js b/benchmark/path/basename-win32.js
@@ -27,7 +27,7 @@ function main({ n, pathext }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.basename(i % 3 === 0 ? `${pathext}${i}` : pathext, ext);
   }
   bench.end(n);

diff --git a/benchmark/path/dirname-posix.js b/benchmark/path/dirname-posix.js
@@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.dirname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/dirname-win32.js b/benchmark/path/dirname-win32.js
@@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.dirname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/extname-posix.js b/benchmark/path/extname-posix.js
@@ -20,7 +20,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.extname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/extname-win32.js b/benchmark/path/extname-win32.js
@@ -20,7 +20,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.extname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/format-posix.js b/benchmark/path/format-posix.js
@@ -20,7 +20,7 @@ function main({ n, props }) {
   };
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     obj.base = `a${i}${props[2] || ''}`;
     obj.name = `a${i}${props[4] || ''}`;
     posix.format(obj);

diff --git a/benchmark/path/format-win32.js b/benchmark/path/format-win32.js
@@ -20,7 +20,7 @@ function main({ n, props }) {
   };
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     obj.base = `a${i}${props[2] || ''}`;
     obj.name = `a${i}${props[4] || ''}`;
     win32.format(obj);

diff --git a/benchmark/path/isAbsolute-posix.js b/benchmark/path/isAbsolute-posix.js
@@ -15,7 +15,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.isAbsolute(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/isAbsolute-win32.js b/benchmark/path/isAbsolute-win32.js
@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.isAbsolute(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/join-posix.js b/benchmark/path/join-posix.js
@@ -15,7 +15,7 @@ function main({ n, paths }) {
   const orig = copy[1];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[1] = `${orig}${i}`;
       posix.join(...copy);

diff --git a/benchmark/path/join-win32.js b/benchmark/path/join-win32.js
@@ -15,7 +15,7 @@ function main({ n, paths }) {
   const orig = copy[1];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[1] = `${orig}${i}`;
       win32.join(...copy);

diff --git a/benchmark/path/makeLong-win32.js b/benchmark/path/makeLong-win32.js
@@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32._makeLong(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/normalize-posix.js b/benchmark/path/normalize-posix.js
@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.normalize(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/normalize-win32.js b/benchmark/path/normalize-win32.js
@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.normalize(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

diff --git a/benchmark/path/resolve-posix.js b/benchmark/path/resolve-posix.js
@@ -18,7 +18,7 @@ function main({ n, paths }) {
   const orig = copy[0];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[0] = `${orig}${i}`;
       posix.resolve(...copy);

diff --git a/benchmark/path/resolve-win32.js b/benchmark/path/resolve-win32.js
@@ -18,7 +18,7 @@ function main({ n, paths }) {
   const orig = copy[0];
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 3 === 0) {
       copy[0] = `${orig}${i}`;
       win32.resolve(...copy);

diff --git a/benchmark/process/memoryUsage.js b/benchmark/process/memoryUsage.js
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     process.memoryUsage();
   }
   bench.end(n);

diff --git a/benchmark/process/next-tick-breadth-args.js b/benchmark/process/next-tick-breadth-args.js
@@ -33,7 +33,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 4 === 0)
       process.nextTick(cb4, 3.14, 1024, true, false);
     else if (i % 3 === 0)

diff --git a/benchmark/process/next-tick-breadth.js b/benchmark/process/next-tick-breadth.js
@@ -15,7 +15,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     process.nextTick(cb);
   }
 }
diff --git a/benchmark/process/next-tick-exec-args.js b/benchmark/process/next-tick-exec-args.js
@@ -10,7 +10,7 @@ function main({ n }) {
       bench.end(n);
   }
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     if (i % 4 === 0)
       process.nextTick(onNextTick, i, true, 10, 'test');
     else if (i % 3 === 0)

diff --git a/benchmark/process/next-tick-exec.js b/benchmark/process/next-tick-exec.js
@@ -10,7 +10,7 @@ function main({ n }) {
       bench.end(n);
   }
 
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     process.nextTick(onNextTick, i);
   }
 

diff --git a/benchmark/process/queue-microtask-breadth.js b/benchmark/process/queue-microtask-breadth.js
@@ -15,7 +15,7 @@ function main({ n }) {
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     queueMicrotask(cb);
   }
 }