Conversation
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. Would be nice to have a doc lint rule.
Agreed. It's a bit annoying that the doc rules exist outside of core. |
Yeah, I'd be for reversing the flow to make this easier on us. In other words, instead of adding a rule to the That might also involve undoing some or all of the rollup stuff for lint-md too, though. |
cjihrig
added
the
author ready
Update the API docs to always spell as Unix. PR-URL: nodejs#28576 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Update the API docs to always spell as Unix. PR-URL: #28576 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
9 participants
Update the API docs to always spell as Unix for consistency.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes