Skip to content

worker: handle calling terminate when kHandler is null #28370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elyalvarado wants to merge 5 commits into from
Closed

worker: handle calling terminate when kHandler is null #28370

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8408ac
worker: handle calling terminate when kHandler is null
elyalvarado Jun 21, 2019
fd8a604
worker: make calling terminate always return a promise
elyalvarado Jun 22, 2019
0cb0c9c
worker: always deprecation warning on terminate if callback supplied
elyalvarado Jun 23, 2019
f07fd01
Rename variable for clarity
elyalvarado Jul 15, 2019
3916e59
Rename variable to reduce line length
elyalvarado Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename variable for clarity
  • Loading branch information
@elyalvarado @Trott
elyalvarado authored and Trott committed Jul 30, 2019
commit f07fd01df386028a421b00f116c6f508fb1112d1
12 changes: 6 additions & 6 deletions test/parallel/test-worker-terminate-null-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,22 @@ const { Worker } = require('worker_threads');
// Test that calling worker.terminate() if kHandler is null should return an
// empty promise that resolves to undefined, even when a callback is passed

const w = new Worker(`
const worker = new Worker(`
const { parentPort } = require('worker_threads');
parentPort.postMessage({ hello: 'world' });
`, { eval: true });

process.once('beforeExit', common.mustCall(() => {
console.log('beforeExit');
w.ref();
worker.ref();
}));

w.on('exit', common.mustCall(() => {
worker.on('exit', common.mustCall(() => {
console.log('exit');
w.terminate().then((returned) => assert.strictEqual(returned, undefined));
w.terminate(() => null).then(
worker.terminate().then((returned) => assert.strictEqual(returned, undefined));
worker.terminate(() => null).then(
(returned) => assert.strictEqual(returned, undefined)
);
}));

w.unref();
worker.unref();