Skip to content

assert: add tests to assert and improve coverage #28355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
estrada9166 wants to merge 4 commits into from
Closed

assert: add tests to assert and improve coverage #28355

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e970a1
Improve coverage for assert.ok
estrada9166 Jun 21, 2019
4a4f668
test: add tests to assert.ok
estrada9166 Jun 23, 2019
62084f4
assert: add tests to assert.ok and improve coverage
estrada9166 Jun 23, 2019
e8077eb
assert: add test to doesNotThrow; validate if actual with regex.
estrada9166 Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert: add tests to assert.ok and improve coverage 
Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L364
  • Loading branch information
@estrada9166
estrada9166 committed Jun 23, 2019
commit 62084f41f298380ce93ece14351e266a0d917381
2 changes: 1 addition & 1 deletion test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ assert.throws(() => a.ok(false), a.AssertionError, 'ok(false)');
threw = true;
assert.ok(e instanceof Error);
}
assert.ok(threw, 'Error: ok(true)');
assert.ok(threw, 'Error: ok(false)');
}


Expand Down