Skip to content

test: normalize location test-worker-process-cwd.js runs tests #28271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssample812 wants to merge 1 commit into from
Closed

test: normalize location test-worker-process-cwd.js runs tests #28271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: normalize location test-worker-process-cwd.js runs tests 
This change sets the process' directory to __dirname in order to
normalize where the test is ran.  This addresses the situation that
occurs when node is located in the root, and moving up a directory
results in the same directory.  In that case, an error was thrown
because the test interpreted this as a failed directory change.

Fixes: #28193
  • Loading branch information
@ssample812
ssample812 committed Jun 17, 2019
commit 484814baca25df3c95d20a95a1cf7e2e2c8fa44d
1 change: 1 addition & 0 deletions test/parallel/test-worker-process-cwd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ if (!process.env.HAS_STARTED_WORKER) {
if (!isMainThread) {
common.skip('This test can only run as main thread');
}
process.chdir(__dirname);
const w = new Worker(__filename);
process.chdir('..');
w.on('message', common.mustCall((message) => {
Expand Down