Skip to content

build: expose napi_build_version variable to native addons #27835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickNaso wants to merge 6 commits into from
Closed

build: expose napi_build_version variable to native addons #27835

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4a965a
build: expose napi_build_version variable to native addons
NickNaso May 23, 2019
5e4f0bb
Retrieve napi_build_version in a dynamic way.
NickNaso Jun 3, 2019
8758973
Fixed lint problem on test and retrtieve N-API version from node_vers…
NickNaso Jun 4, 2019
cc8031b
Added some comments about NAPI_VERSION
NickNaso Jun 10, 2019
a46ad00
Fixed typo
NickNaso Jun 13, 2019
0bf6549
Fixed style on configure_napi function.
NickNaso Jun 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added some comments about NAPI_VERSION
  • Loading branch information
@NickNaso
NickNaso committed Jun 10, 2019
commit cc8031b6bf2b1b3419da9a4ffb51fdd1ccca6bb3
7 changes: 6 additions & 1 deletion src/js_native_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@
#ifdef NAPI_EXPERIMENTAL
#define NAPI_VERSION NAPI_VERSION_EXPERIMENTAL
#else
// The baseline version for N-API
// The baseline version for N-API.
// The NAPI_VERSION controls which version will be used by default when
// compilling a native addon. If the addon developer specifically wants to use
// functions available in a new version of N-API that is not yet ported in all
// LTS version, they can set NAPI_VERSION knowing that they have specifically
// depended on that version.
#define NAPI_VERSION 4
#endif
#endif
Expand Down
3 changes: 2 additions & 1 deletion src/node_version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@
*/
#define NODE_MODULE_VERSION 72

// the NAPI_VERSION provided by this version of the runtime
// The NAPI_VERSION provided by this version of the runtime. This is the version
// which the Node binary being built supports.
#define NAPI_VERSION 4

#endif // SRC_NODE_VERSION_H_