Skip to content

stream: make async iteration stable #26989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
Closed

stream: make async iteration stable #26989

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9636a35
stream: make async iteration stable
mcollina Mar 29, 2019
8df8328
readline: make AsyncIterator stable
mcollina Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
readline: make AsyncIterator stable
  • Loading branch information
@mcollina
mcollina committed Apr 1, 2019
commit 8df8328b142fd759189fd70dd30cce779f4c9583
6 changes: 5 additions & 1 deletion doc/api/readline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,13 @@ The `rl.write()` method will write the data to the `readline` `Interface`'s
### rl\[Symbol.asyncIterator\]()
<!-- YAML
added: v11.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/26989
description: AsyncIterator support is not experimental anymore.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable

* Returns: {AsyncIterator}

Expand Down
3 changes: 0 additions & 3 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const {
} = require('internal/errors').codes;
const { validateString } = require('internal/validators');
const { inspect } = require('internal/util/inspect');
const { emitExperimentalWarning } = require('internal/util');
const EventEmitter = require('events');
const {
CSI,
Expand Down Expand Up @@ -1068,8 +1067,6 @@ Interface.prototype._ttyWrite = function(s, key) {
};

Interface.prototype[Symbol.asyncIterator] = function() {
emitExperimentalWarning('readline Interface [Symbol.asyncIterator]');

if (this[kLineObjectStream] === undefined) {
if (Readable === undefined) {
Readable = require('stream').Readable;
Expand Down