Skip to content

crypto: don't crash on unknown keyObject.asymmetricKeyType #26786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 7 commits into from
Closed

crypto: don't crash on unknown keyObject.asymmetricKeyType #26786

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e6d7fd
crypto: don't crash on unknown keyObject.asymmetricKeyType
panva Mar 19, 2019
9beb4c6
fixup! crypto: don't crash on unknown keyObject.asymmetricKeyType
panva Mar 19, 2019
6dfbf82
fixup! crypto: don't crash on unknown keyObject.asymmetricKeyType
panva Mar 19, 2019
07747f9
fixup! crypto: don't crash on unknown keyObject.asymmetricKeyType
panva Mar 19, 2019
2607794
fixup! crypto: don't crash on unknown keyObject.asymmetricKeyType
panva Mar 20, 2019
20b4d8f
fixup! crypto: don't crash on unknown keyObject.asymmetricKeyType
panva Mar 20, 2019
7f386e9
apply feedback
panva Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! crypto: don't crash on unknown keyObject.asymmetricKeyType
  • Loading branch information
@panva
panva committed Mar 29, 2019
commit 6dfbf82129e24276d4bf3fc49b96ccdabfa75b96
4 changes: 2 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,8 +1145,8 @@ changes:

For asymmetric keys, this property represents the type of the embedded key
(`'rsa'`, `'dsa'`, `'ec'`, `'ed25519'`, `'ed448'`, `'x25519'` or `'x448'`).
This property is `undefined` for symmetric keys and `'unknown'` for `KeyObject`
objects that aren
This property is `undefined` for symmetric keys and `'unknown'` for
unrecognized `KeyObject` types.

### keyObject.export([options])
<!-- YAML
Expand Down