Skip to content

crypto: add API to retrieve key type OID #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 2 commits into from
Closed

crypto: add API to retrieve key type OID #26709

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57908c9
crypto: add API to retrieve key type OID
tniessen Mar 17, 2019
a030a5d
fixup! crypto: add API to retrieve key type OID
tniessen Mar 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! crypto: add API to retrieve key type OID
  • Loading branch information
@tniessen
tniessen committed Mar 17, 2019
commit a030a5d6603a99bc1eaead3293caa04e6c859364
16 changes: 16 additions & 0 deletions test/parallel/test-crypto-keygen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ if (!common.hasCrypto)

const assert = require('assert');
const {
createPrivateKey,
createPublicKey,
createSign,
createVerify,
generateKeyPair,
Expand Down Expand Up @@ -275,6 +277,15 @@ const sec1EncExp = (cipher) => getRegExpForPEM('EC PRIVATE KEY', cipher);
assertApproximateSize(publicKey, 440);
assertApproximateSize(privateKeyDER, 336);

assert.strictEqual(createPublicKey(publicKey).asymmetricKeyTypeOid,
'1.2.840.10040.4.1');
assert.strictEqual(createPrivateKey({
key: privateKeyDER,
...privateKeyEncoding,
passphrase: 'secret'
}).asymmetricKeyTypeOid,
'1.2.840.10040.4.1');

// Since the private key is encrypted, signing shouldn't work anymore.
assert.throws(() => {
testSignVerify(publicKey, {
Expand Down Expand Up @@ -314,6 +325,11 @@ const sec1EncExp = (cipher) => getRegExpForPEM('EC PRIVATE KEY', cipher);
assert.strictEqual(typeof privateKey, 'string');
assert(sec1Exp.test(privateKey));

assert.strictEqual(createPublicKey(publicKey).asymmetricKeyTypeOid,
'1.2.840.10045.2.1');
assert.strictEqual(createPrivateKey(privateKey).asymmetricKeyTypeOid,
'1.2.840.10045.2.1');

testSignVerify(publicKey, privateKey);
}));

Expand Down