Skip to content

http: check "parser" existence in various conditions for http client #26486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BeniCheni wants to merge 6 commits into from
Closed

http: check "parser" existence in various conditions for http client #26486

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d20e94
http: check parser in various logic; update const and let variables
BeniCheni Mar 7, 2019
9478a91
test: revert const or let to var in _http_client.js for a separate PR
BeniCheni Mar 7, 2019
5decc23
test: retain const in original code of _http_client.js
BeniCheni Mar 7, 2019
266f5a5
test: retain const of INVALID_PATH_REGEX variable of _http_client.js
BeniCheni Mar 7, 2019
322119c
test: format whitespace _http_client.js
BeniCheni Mar 7, 2019
59eb756
test: correct indention in _http_client.js per make lint
BeniCheni Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: retain const of INVALID_PATH_REGEX variable of _http_client.js
  • Loading branch information
@BeniCheni
BeniCheni committed Mar 7, 2019
commit 266f5a508d9ebd5d87a1a232f7ea48857a45a956
2 changes: 1 addition & 1 deletion lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const {
const { validateTimerDuration } = require('internal/timers');
const is_reused_symbol = require('internal/freelist').symbols.is_reused_symbol;

var INVALID_PATH_REGEX = /[^\u0021-\u00ff]/;
const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/;

function validateHost(host, name) {
if (host !== null && host !== undefined && typeof host !== 'string') {
Expand Down