Skip to content

[v11.x backport] src: simplify NativeModule caching and remove redundant data #25964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antsmartian wants to merge 2 commits into from
Closed

[v11.x backport] src: simplify NativeModule caching and remove redundant data #25964

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd4e41
src: simplify NativeModule caching and remove redundant data
joyeecheung Jan 4, 2019
c5a7fed
fixup! src: simplify NativeModule caching and remove redundant data
addaleax Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: simplify NativeModule caching and remove redundant data
  • Loading branch information
@addaleax
addaleax committed Feb 6, 2019
commit c5a7fedc730b48e88b9a955563bb0fa63abcec8d
3 changes: 2 additions & 1 deletion lib/internal/bootstrap/cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ if (!process.versions.openssl) {

const cachableBuiltins = [];
for (const id of NativeModule.map.keys()) {
if (id.startsWith('internal/deps')) {
if (id.startsWith('internal/deps') ||
id.startsWith('v8/') || id.startsWith('node-inspect/')) {
cannotUseCache.push(id);
}
if (!cannotUseCache.includes(id)) {
Expand Down