build: remove AIX/ppc (32bit) dead code by refack · Pull Request #25523 · nodejs/node

refack · 2019-01-15T18:42:43Z

also refactor OS400 detection

Refs: https://github.com/nodejs/node/pull/25447/files/36839defcfaf7c46435e16fb1f0da006f3ebe8ac#r247378894

/CC @nodejs/build-files @nodejs/platform-aix

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-01-15T18:42:45Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2257/pipeline

refack · 2019-01-15T18:43:44Z

~~AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/20427/~~
AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/20430/

mhdawson · 2019-01-17T14:30:34Z

@gireeshpunathil
@ThePrez

Can you two take a look and comment if you have any concerns.

gireeshpunathil · 2019-01-17T14:42:11Z

the configure error
21:24:54 gyp: Undefined variable aix_variant_name in /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/node.gyp while trying to load

looks to be relevant here, as we moved a section containing aix_variant_name

ThePrez · 2019-01-17T18:09:07Z

LGTM, though I haven't tested with the changes. @dmabupt, can you please sanity-check?

refack · 2019-01-17T18:31:22Z

https://ci.nodejs.org/job/node-test-commit-aix/20476/
Latest change gets code to build, PTAL.

richardlau · 2019-01-17T23:49:37Z

There's similar code in node.gyp:

node/node.gyp

Lines 973 to 1000 in 098c2cc

    
           'variables': {'real_os_name': '<!(uname -s)',}, 
        
           'targets': [ 
        
             { 
        
               'target_name': 'node_aix_shared', 
        
               'type': 'shared_library', 
        
               'product_name': '<(node_core_target_name)', 
        
               'ldflags': [ '--shared' ], 
        
               'product_extension': '<(shlib_suffix)', 
        
               'conditions': [ 
        
                 ['target_arch=="ppc64"', { 
        
                   'ldflags': [ 
        
                     '-Wl,-blibpath:/usr/lib:/lib:' 
        
                       '/opt/freeware/lib/pthread/ppc64' 
        
                   ], 
        
                 }], 
        
                 ['target_arch=="ppc"', { 
        
                   'ldflags': [ 
        
                     '-Wl,-blibpath:/usr/lib:/lib:/opt/freeware/lib/pthread' 
        
                   ], 
        
                 }], 
        
                 ['"<(real_os_name)"=="OS400"', { 
        
                   'ldflags': [ 
        
                     '-Wl,-blibpath:/QOpenSys/pkgs/lib:/QOpenSys/usr/lib', 
        
                     '-Wl,-bbigtoc', 
        
                     '-Wl,-brtl', 
        
                   ], 
        
                 }], 
        
               ],

common.gypi

refack · 2019-01-19T19:36:22Z

CI: https://ci.nodejs.org/job/node-test-commit-aix/20503/

dmabupt · 2019-01-22T01:22:50Z

This line is not needed anymore --> https://github.com/nodejs/node/pull/25523/files#diff-259e627be3fafed9e9c10a7fcb26879eR970

common.gypi

node.gyp

refack · 2019-01-22T16:47:05Z

~~New AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/20560/~~
New AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/20561/ (✔️)
AIX + shared: https://ci.nodejs.org/job/node-test-commit-aix-shared-lib/256/ (⚠️ stable)

@dmabupt, can you verify this builds on IBM i (also with ./configure --shared)?

common.gypi

refack · 2019-01-22T16:59:06Z

It'll probably be evident in the CI, but we need to pass -maix64 to the linker as well as the compiler.

FTR, this is a sample error message from ld:

ld: 0711-736 ERROR: Input file /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/obj.host/genccode/deps/icu-small/source/tools/genccode/genccode.o:
 	XCOFF64 object files are not allowed in 32-bit mode.

dmabupt · 2019-01-23T04:50:31Z

New AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/20560/
New AIX CI: https://ci.nodejs.org/job/node-test-commit-aix/20561/ ()
AIX + shared: https://ci.nodejs.org/job/node-test-commit-aix-shared-lib/256/ ( stable)

@dmabupt, can you verify this builds on IBM i (also with ./configure --shared)?

I have built Node.js on IBM i with / without the --shared option. Both builds passed.

refack · 2019-01-23T19:27:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20291/
Resume: https://ci.nodejs.org/job/node-test-pull-request/20293/

* also dedup OS400 detection PR-URL: nodejs#25523 Refs: https://github.com/nodejs/node/pull/25447/files/36839defcfaf7c46435e16fb1f0da006f3ebe8ac#r247378894 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>

* also dedup OS400 detection PR-URL: #25523 Refs: https://github.com/nodejs/node/pull/25447/files/36839defcfaf7c46435e16fb1f0da006f3ebe8ac#r247378894 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 15, 2019

refack added the aix Issues and PRs related to the AIX platform. label Jan 15, 2019

phillipj mentioned this pull request Jan 15, 2019

sadly an error occured when I tried to trigger a build :( nodejs/github-bot#210

Closed

jasnell approved these changes Jan 18, 2019

View reviewed changes

richardlau reviewed Jan 18, 2019

View reviewed changes

common.gypi Outdated Show resolved Hide resolved

refack self-assigned this Jan 19, 2019

dmabupt reviewed Jan 22, 2019

View reviewed changes

common.gypi Outdated Show resolved Hide resolved

dmabupt reviewed Jan 22, 2019

View reviewed changes

node.gyp Outdated Show resolved Hide resolved

richardlau reviewed Jan 22, 2019

View reviewed changes

common.gypi Outdated Show resolved Hide resolved

richardlau approved these changes Jan 23, 2019

View reviewed changes

BethGriggs approved these changes Jan 23, 2019

View reviewed changes

refack force-pushed the aix-gyp-cleanup branch from b80788c to 416a9fd Compare January 23, 2019 22:55

refack force-pushed the aix-gyp-cleanup branch from 416a9fd to b1a4e41 Compare January 23, 2019 22:56

refack merged commit b1a4e41 into nodejs:master Jan 23, 2019

refack deleted the aix-gyp-cleanup branch January 23, 2019 22:58

MylesBorins mentioned this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

refack removed their assignment Mar 11, 2019

BethGriggs mentioned this pull request May 1, 2019

v10.16.0 proposal #27514

Merged

Uh oh!

Conversation

refack commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Jan 15, 2019

Uh oh!

refack commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhdawson commented Jan 17, 2019

Uh oh!

gireeshpunathil commented Jan 17, 2019

Uh oh!

ThePrez commented Jan 17, 2019

Uh oh!

refack commented Jan 17, 2019

Uh oh!

richardlau commented Jan 17, 2019

Uh oh!

Uh oh!

refack commented Jan 19, 2019

Uh oh!

dmabupt commented Jan 22, 2019

Uh oh!

Uh oh!

Uh oh!

refack commented Jan 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

refack commented Jan 22, 2019

Uh oh!

dmabupt commented Jan 23, 2019

Uh oh!

refack commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

refack commented Jan 15, 2019 •

edited

Loading

refack commented Jan 15, 2019 •

edited

Loading

refack commented Jan 22, 2019 •

edited

Loading

refack commented Jan 23, 2019 •

edited

Loading