Skip to content

test: tune test-uv-threadpool-schedule #25358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: tune test-uv-threadpool-schedule #25358

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a963ae1
test: tune test-uv-threadpool-schedule
Trott Jan 6, 2019
ab6cbd4
fixup! test: tune test-uv-threadpool-schedule
Trott Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: tune test-uv-threadpool-schedule
  • Loading branch information
@Trott
Trott committed Jan 6, 2019
commit ab6cbd411c84a8a995a967851ca4ebdacd45aa01
6 changes: 3 additions & 3 deletions test/internet/test-uv-threadpool-schedule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const assert = require('assert');

const start = Date.now();

const slowIOmax = 10;
const slowIOmax = 100;
let slowIOcount = 0;
let fastIOdone = false;
let slowIOend, fastIOend;
Expand All @@ -31,13 +31,13 @@ function onResolve() {
'fast I/O was throttled due to threadpool congestion.');

// More realistic expectation: finish disc I/O at least within
// a time duration that is 1/100th of net I/O.
// a time duration that is half of net I/O.
// Ideally the slow I/O should not affect the fast I/O as those
// have two different thread-pool buckets. However, this could be
// highly load / platform dependent, so don't be very greedy.
const fastIOtime = fastIOend - start;
const slowIOtime = slowIOend - start;
const expectedMax = slowIOtime / 10;
const expectedMax = slowIOtime / 2;
assert.ok(fastIOtime < expectedMax,
'fast I/O took longer to complete, ' +
`actual: ${fastIOtime}, expected: ${expectedMax}`);
Expand Down