Skip to content

v8.15.0 proposal #25177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MylesBorins merged 7 commits into from
Dec 26, 2018
Merged

v8.15.0 proposal #25177

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aef71c0
test: mark test-http2-settings-flood as flaky on Windows
Trott Dec 14, 2018
e1fbc26
test: move test-benchmark-path to sequential
Trott Jun 18, 2018
215ecfe
http: fix regression of binary upgrade response body
mcollina Dec 14, 2018
4fb5a1b
deps: cherry-pick http_parser_set_max_header_size
cjihrig Nov 29, 2018
693e362
cli: add --max-http-header-size flag
cjihrig Dec 3, 2018
446f8b5
http: add maxHeaderSize property
cjihrig Dec 6, 2018
6d1c367
2018-12-26, Version 8.15.0 'Carbon' (LTS)
MylesBorins Dec 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: fix regression of binary upgrade response body 
See: #24958

PR-URL: #25037
Reviewed-By: Myles Borins <[email protected]>
  • Loading branch information
@mcollina @MylesBorins
mcollina authored and MylesBorins committed Dec 22, 2018
commit 215ecfe4de0bcab2c2ed0d23923a0c7c87abd733
6 changes: 3 additions & 3 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,8 +621,6 @@ class Parser : public AsyncWrap {
size_t nparsed =
http_parser_execute(&parser_, &settings, data, len);

enum http_errno err = HTTP_PARSER_ERRNO(&parser_);

Save();

// Unassign the 'buffer_' variable
Expand All @@ -637,7 +635,9 @@ class Parser : public AsyncWrap {
Local<Integer> nparsed_obj = Integer::New(env()->isolate(), nparsed);
// If there was a parse error in one of the callbacks
// TODO(bnoordhuis) What if there is an error on EOF?
if ((!parser_.upgrade && nparsed != len) || err != HPE_OK) {
if (!parser_.upgrade && nparsed != len) {
enum http_errno err = HTTP_PARSER_ERRNO(&parser_);

Local<Value> e = Exception::Error(env()->parse_error_string());
Local<Object> obj = e->ToObject(env()->isolate());
obj->Set(env()->bytes_parsed_string(), nparsed_obj);
Expand Down