Skip to content

win, build: fix building addons on Windows #25108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bzoz wants to merge 1 commit into from
+2 −2
Closed

win, build: fix building addons on Windows #25108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
win, build: fix building addons on Windows 
Building addons would fail because addon-verify.js dependencies from
tools\doc where not installed. This fixes this issue by installing
those dependencies if addons are to be built.

Fixes: #25096
  • Loading branch information
@bzoz
bzoz committed Dec 18, 2018
commit 64d5574db6ee958a038c686355a120835bdcd7ab
4 changes: 2 additions & 2 deletions vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ if errorlevel 1 goto exit


:install-doctools
REM only install if building doc OR testing doctool
if not defined doc (
REM only install if building doc OR testing doctool OR building addons
if not defined doc if not defined build_addons (
echo.%test_args% | findstr doctool 1>nul
if errorlevel 1 goto :skip-install-doctools
)
Expand Down