Skip to content

http_parser: fix error return in Finish() #24738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 3 commits into from
Closed

http_parser: fix error return in Finish() #24738

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95bd7b2
http: fix error return in `Finish()`
indutny Nov 30, 2018
12f9b6a
test: add test
indutny Nov 30, 2018
dc7beec
fix nit
indutny Dec 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix nit
  • Loading branch information
@indutny
indutny committed Dec 2, 2018
commit dc7beec6103fc3b7412e081fdd94e1a0a75364ae
1 change: 0 additions & 1 deletion test/parallel/test-http-parser-finish-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const server = http.createServer(common.mustNotCall());
server.on('clientError', common.mustCall((err, socket) => {
assert(/^Parse Error/.test(err.message));
assert.strictEqual(err.code, 'HPE_INVALID_EOF_STATE');
server.close();
socket.destroy();
}, 1));
server.listen(0, () => {
Expand Down