Skip to content

lib: fix worker threads can't read stdout #24652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leeight wants to merge 1 commit into from
Closed

lib: fix worker threads can't read stdout #24652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: fix worker threads can't read stdout 
Fix: #24636
  • Loading branch information
@leeight
leeight committed Nov 26, 2018
commit d2beb1c9eafccebfa89edd3402cbc585ae1af79c
14 changes: 12 additions & 2 deletions lib/internal/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,12 +343,22 @@ class Worker extends EventEmitter {
case messageTypes.STDIO_PAYLOAD:
{
const { stream, chunk, encoding } = message;
return this[kParentSideStdio][stream].push(chunk, encoding);
if (this[kParentSideStdio]) {
this[kParentSideStdio][stream].push(chunk, encoding);
} else {
debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
}
return;
}
case messageTypes.STDIO_WANTS_MORE_DATA:
{
const { stream } = message;
return this[kParentSideStdio][stream][kStdioWantsMoreDataCallback]();
if (this[kParentSideStdio]) {
this[kParentSideStdio][stream][kStdioWantsMoreDataCallback]();
} else {
debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
}
return;
}
}

Expand Down