Skip to content

deps/npm: Use print() function on both Python 2 and 3#24487

Closed
cclauss wants to merge 1 commit intonodejs:masterfrom
cclauss:deps-print-function
Closed

deps/npm: Use print() function on both Python 2 and 3#24487
cclauss wants to merge 1 commit intonodejs:masterfrom
cclauss:deps-print-function

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 19, 2018 •
edited
Loading

A subset of #23669 to simplify the review process. @refack @addaleax

The openssl change was merged into upstream in openssl/openssl#7409

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. openssl Issues and PRs related to the OpenSSL dependency. labels Nov 19, 2018
@cclauss cclauss force-pushed the deps-print-function branch 2 times, most recently from 5270045 to 60520e0 Compare November 19, 2018 12:16
@cclauss cclauss force-pushed the deps-print-function branch from 60520e0 to 85f9795 Compare November 19, 2018 12:17
@jasnell
Copy link
Member

jasnell commented Nov 19, 2018

Changes to deps need to be landed upstream. We cannot land changes like this without them landing there first.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 19, 2018 •
edited
Loading

Thanks @jasnell but what exactly is upstream for deps/npm? https://github.com/npm/npm moved to https://github.com/npm/cli but that repo contains no Python code.

@targos
Copy link
Member

targos commented Nov 19, 2018

The upstream here would be node-gyp: https://github.com/nodejs/node-gyp

@refack
Copy link
Contributor

refack commented Nov 19, 2018

To resolve this we need to release a new version of node-gyp that will include @cclauss's nodejs/node-gyp#1335, and then get npm to adopt it.
Anyway the deps directory as a whole should be kept being excluded from the regular python linting since it's vendored code. As it is now:

node/Makefile

Lines 1228 to 1231 in 4327326

lint-py:
PYTHONPATH=tools/pip $(PYTHON) -m flake8 . \
--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
--exclude=deps,lib,src,tools/*_macros.py,tools/gyp,tools/jinja2,tools/pip

@refack refack added the wrong repo Issues that should be opened in another repository. label Nov 19, 2018
@refack
Copy link
Contributor

refack commented Nov 19, 2018 •
edited
Loading

@cclauss I'm going to close this issue as wrong-repo which indicates that the requested change should happen elsewhere upstream.

P.S. thank you very much for the effort!

@refack refack closed this Nov 19, 2018
@refack
Copy link
Contributor

refack commented Nov 19, 2018 •
edited
Loading

P.S. as for the openSSL tool you might want to open a PR at for https://github.com/openssl/openssl/tree/master/fuzz

P.S. 🤣 just found openssl/openssl@83e4533#diff-96834629132c625c44b0d575f898c511

@refack refack added the python PRs and issues that require attention from people who are familiar with Python. label Nov 19, 2018
@cclauss cclauss deleted the deps-print-function branch November 19, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npm Issues and PRs related to the npm client dependency or the npm registry. openssl Issues and PRs related to the OpenSSL dependency. python PRs and issues that require attention from people who are familiar with Python. wrong repo Issues that should be opened in another repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cclauss @jasnell @targos @refack @nodejs-github-bot

Comments