Skip to content

Release proposal: v3.1.0 #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fishrock123 wants to merge 11 commits into from
Closed

Release proposal: v3.1.0 #2346

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0bb099f
build: expand ~ in install prefix early
bnoordhuis Aug 5, 2015
2f154b5
doc: multiple documentation updates cherry picked from v0.12
jasnell Jun 24, 2015
c8282de
test: address timing issues in simple http tests
gireeshpunathil Mar 18, 2015
6f89de9
net: ensure Socket reported address is current
rmg Jul 2, 2015
6ef7aea
test: make listen-fd-cluster/server more robust
sam-github Jun 10, 2015
51b6bdc
tls: introduce internal `onticketkeycallback`
indutny Aug 8, 2015
581850b
tls: fix check for reused session
indutny Aug 8, 2015
ee9dd68
util: display constructor when inspecting objects
monsanto Jun 10, 2015
3a48c72
build: update manifest to include Windows 10
LPGhatguy Aug 9, 2015
4750a2a
path: remove dead code in favor of unit tests
nwoltman Jul 31, 2015
bed03ea
test: clarify dropMembership() call
Trott Jun 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: clarify dropMembership() call 
According to docs, dropMembership() is automatically called
by the kernel when the socket is closed, and most apps will
never need to call it. It's called here as a sanity check
only so let's note that with a comment.

Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: #2062
  • Loading branch information
@Trott @Fishrock123
Trott authored and Fishrock123 committed Aug 11, 2015
commit bed03ea143f3d260e192137d67fc5efa21a26731
6 changes: 2 additions & 4 deletions test/internet/test-dgram-multicast-multi-process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ var common = require('../common'),
assert = require('assert'),
dgram = require('dgram'),
util = require('util'),
assert = require('assert'),
Buffer = require('buffer').Buffer,
fork = require('child_process').fork,
LOCAL_BROADCAST_HOST = '224.0.0.114',
Expand Down Expand Up @@ -183,10 +182,9 @@ if (process.argv[2] === 'child') {
process.send({ message: buf.toString() });

if (receivedMessages.length == messages.length) {
// .dropMembership() not strictly needed but here as a sanity check
listenSocket.dropMembership(LOCAL_BROADCAST_HOST);

process.nextTick(function() { // TODO should be changed to below.
// listenSocket.dropMembership(LOCAL_BROADCAST_HOST, function() {
process.nextTick(function() {
listenSocket.close();
});
}
Expand Down